Skip to content

fix(release): use dots instead of dashes in release assets name version #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sh4d1 merged 1 commit into from
Oct 20, 2020
Merged

fix(release): use dots instead of dashes in release assets name version #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

# Download the release from github
curl -o /usr/local/bin/scw -L "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2-2-0-darwin-x86_64"
curl -o /usr/local/bin/scw -L "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2.2.0-darwin-x86_64"

# Allow executing file as program
chmod +x /usr/local/bin/scw
Expand All @@ -78,7 +78,7 @@ scw init

```bash
# Download the release from github
sudo curl -o /usr/local/bin/scw -L "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2-2-0-linux-x86_64"
sudo curl -o /usr/local/bin/scw -L "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2.2.0-linux-x86_64"

# Allow executing file as program
sudo chmod +x /usr/local/bin/scw
Expand All @@ -89,7 +89,7 @@ scw init

#### Windows

You can download the last release here: https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2-2-0-windows-x86_64.exe<br/>
You can download the last release here: https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-2.2.0-windows-x86_64.exe<br/>
[This official guide](https://docs.microsoft.com/en-us/previous-versions/office/developer/sharepoint-2010/ee537574%28v%3Doffice.14%29) explains how to add tools to your `PATH`.

<!-- TODO:
Expand All @@ -100,7 +100,7 @@ First, download [the `.deb` file](https://github.com/scaleway/scaleway-cli/relea

```bash
export ARCH=amd64 # Can be 'amd64', 'arm', 'arm64' or 'i386'
wget "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-v2-2-0-${ARCH}.deb" -O /tmp/scw.deb
wget "https://github.com/scaleway/scaleway-cli/releases/download/v2.2.0/scw-v2.2.0-${ARCH}.deb" -O /tmp/scw.deb
```

Then, run the installation and remove the `.deb` file:
Expand Down
13 changes: 5 additions & 8 deletions scripts/release/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ async function main() {
.filter(semver.valid)
.sort((a, b) => semver.rcompare(semver.clean(a), semver.clean(b)))[0];
const lastVersion = semver.clean(lastSemverTag);
const lastVersionWithDash = lastVersion.replace(/\./g, "-");
console.log(` Last found release tag was ${lastSemverTag}`.green);

console.log("Listing commit since last release".blue);
Expand All @@ -162,7 +161,6 @@ async function main() {
if (!newVersion) {
throw new Error(`invalid version`);
}
const newVersionWithDash = newVersion.replace(/\./g, "-");

//
// Creating release commit
Expand All @@ -173,7 +171,6 @@ async function main() {
changelog.body = externalEditor.edit(changelog.body);

replaceInFile(README_PATH, lastVersion, newVersion);
replaceInFile(README_PATH, lastVersionWithDash, newVersionWithDash);
replaceInFile(CHANGELOG_PATH, "# Changelog", `# Changelog\n\n${changelog.header}\n\n${changelog.body}\n`);
replaceInFile(GO_VERSION_PATH, /Version = "[^"]*"/, `Version = "v${newVersion}"`);
console.log(` Update success`.green);
Expand Down Expand Up @@ -217,11 +214,11 @@ async function main() {

console.log(" attach assets to the release".gray);
const releaseAssets = [
`scw-${newVersionWithDash}-darwin-x86_64`,
`scw-${newVersionWithDash}-linux-x86_64`,
`scw-${newVersionWithDash}-linux-386`,
`scw-${newVersionWithDash}-windows-x86_64.exe`,
`scw-${newVersionWithDash}-windows-386.exe`,
`scw-${newVersion}-darwin-x86_64`,
`scw-${newVersion}-linux-x86_64`,
`scw-${newVersion}-linux-386`,
`scw-${newVersion}-windows-x86_64.exe`,
`scw-${newVersion}-windows-386.exe`,
`SHA256SUMS`,
];
await Promise.all(releaseAssets.map((assetName) => {
Expand Down