Skip to content

feat(instance): rename project to project-id#1410

Merged
QuentinBrosse merged 8 commits intomasterfrom
instance_project
Sep 9, 2020
Merged

feat(instance): rename project to project-id#1410
QuentinBrosse merged 8 commits intomasterfrom
instance_project

Conversation

@Sh4d1
Copy link
Copy Markdown
Contributor

@Sh4d1 Sh4d1 commented Sep 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

kindermoumoute
kindermoumoute requested changes Sep 8, 2020
View reviewed changes
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
@QuentinBrosse QuentinBrosse mentioned this pull request Sep 8, 2020
Merged
kindermoumoute
kindermoumoute requested changes Sep 9, 2020
View reviewed changes
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
QuentinBrosse
QuentinBrosse suggested changes Sep 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enjoy

Comment thread internal/namespaces/instance/v1/custom_image.go Outdated
Comment thread internal/namespaces/instance/v1/custom_image.go Outdated
Comment thread cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden
Comment thread cmd/scw/testdata/test-all-usage-instance-placement-group-create-usage.golden
Comment thread cmd/scw/testdata/test-all-usage-instance-security-group-update-usage.golden
Comment thread cmd/scw/testdata/test-all-usage-instance-volume-list-usage.golden
Comment thread cmd/scw/testdata/test-all-usage-rdb-certificate-get-usage.golden
Comment thread go.sum
Comment thread internal/namespaces/instance/v1/custom_server_create.go
Comment thread internal/namespaces/instance/v1/custom_server_create.go Outdated
QuentinBrosse
QuentinBrosse suggested changes Sep 9, 2020
View reviewed changes
Comment thread internal/namespaces/instance/v1/custom_security_group.go
kindermoumoute
kindermoumoute previously approved these changes Sep 9, 2020
View reviewed changes
Sh4d1 added 8 commits September 9, 2020 16:50
@Sh4d1
feat(instance): rename project to project-id
ecaaaaf 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
test(instance): bump goldens
4261b57 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
chore(core): bump sdk
56f9206 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
fix review
ad85a14 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
fix review
c39080e 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
update goldens
0126576 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
bump cassettes
d0a30c7 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
@Sh4d1
go mod tidy
de3771c 
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
QuentinBrosse
QuentinBrosse approved these changes Sep 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit f7ee6a4 into master Sep 9, 2020
@kindermoumoute kindermoumoute deleted the instance_project branch September 9, 2020 15:59
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

+1 more reviewer

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sh4d1 @kindermoumoute @QuentinBrosse @remyleone