Skip to content

feat(qa): add a qa about commands without examples#1298

Merged
remyleone merged 8 commits intoscaleway:masterfrom
remyleone:qa_missing_example
Aug 11, 2020
Merged

feat(qa): add a qa about commands without examples#1298
remyleone merged 8 commits intoscaleway:masterfrom
remyleone:qa_missing_example

Conversation

@remyleone
Copy link
Copy Markdown
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Comment thread internal/qa/qa.go Outdated
kindermoumoute
kindermoumoute previously approved these changes Aug 11, 2020
Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit but LGTM

Comment thread internal/qa/qa.go Outdated
@kindermoumoute kindermoumoute dismissed jerome-quere’s stale review August 11, 2020 11:25

duplicates latest review

Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
@remyleone remyleone merged commit b6bff44 into scaleway:master Aug 11, 2020
@remyleone remyleone deleted the qa_missing_example branch August 11, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants