Skip to content

feat: add cross reference pn_id in rdb instance#81

Merged
remyleone merged 3 commits intoscaleway:mainfrom
yfodil:feat/add-rdb-pnid-ref
Jun 28, 2024
Merged

feat: add cross reference pn_id in rdb instance#81
remyleone merged 3 commits intoscaleway:mainfrom
yfodil:feat/add-rdb-pnid-ref

Conversation

@yfodil
Copy link
Copy Markdown
Contributor

@yfodil yfodil commented Jun 28, 2024

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@yfodil yfodil added the enhancement New feature or request label Jun 28, 2024
@yfodil yfodil self-assigned this Jun 28, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 28, 2024

Codecov Report

❌ Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@3e32178). Learn more about missing BASE report.

Files with missing lines Patch % Lines
apis/rdb/v1alpha1/zz_generated.resolvers.go 0.00% 35 Missing ⚠️
apis/rdb/v1alpha1/zz_generated.deepcopy.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #81   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?     309           
  Lines           ?   30567           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?   30567           
  Partials        ?       0           
Flag Coverage Δ
unittests 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfodil yfodil linked an issue Jun 28, 2024 that may be closed by this pull request
@remyleone remyleone enabled auto-merge June 28, 2024 16:09
@remyleone remyleone added this pull request to the merge queue Jun 28, 2024
Merged via the queue into scaleway:main with commit 6e57a22 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Best way to attach a managed database to a private network

3 participants