Skip to content

Make sure all the resources are namespaced#25

Merged
nox-404 merged 1 commit intoscaleway:mainfrom
draca-be:fix-bundle
May 8, 2024
Merged

Make sure all the resources are namespaced#25
nox-404 merged 1 commit intoscaleway:mainfrom
draca-be:fix-bundle

Conversation

@MathyV
Copy link
Copy Markdown
Contributor

@MathyV MathyV commented May 8, 2024

Fixes: #24

@nox-404
Copy link
Copy Markdown
Contributor

nox-404 commented May 8, 2024

Hey, thanks for the fix, some of those resources are not namespaced, we could remove the namespace field for those

@MathyV
Copy link
Copy Markdown
Contributor Author

MathyV commented May 8, 2024

Indeed, it seems I went a bit overboard :-) I removed the namespaces from the ClusterRole, ClusterRoleBinding and APIService

Copy link
Copy Markdown
Contributor

@nox-404 nox-404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nox-404 nox-404 merged commit 51afbfd into scaleway:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The bundle.yaml file does not contain all required namespaces

2 participants