Skip to content

fix(vpc): switch to V2 api #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

Mia-Cross
Copy link
Contributor

This PR updates the VPC Private Network resource to use the V2 API, making the resource regional.

@Mia-Cross Mia-Cross self-assigned this Jun 2, 2025
@Mia-Cross Mia-Cross added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Jun 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@634f828). Learn more about missing BASE report.

Files with missing lines Patch % Lines
plugins/modules/scaleway_vpc_private_network.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage        ?   33.12%           
=======================================
  Files           ?       66           
  Lines           ?     4118           
  Branches        ?      801           
=======================================
  Hits            ?     1364           
  Misses          ?     2754           
  Partials        ?        0           
Flag Coverage Δ
sanity 33.12% <14.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mia-Cross Mia-Cross marked this pull request as ready for review June 4, 2025 13:40
@Mia-Cross Mia-Cross requested a review from remyleone as a code owner June 4, 2025 13:40
Copy link
Contributor

@Gnoale Gnoale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration test ? 🙏

@Mia-Cross Mia-Cross force-pushed the vpc_fix_switch_to_v2 branch from 233c8e0 to 3382c1f Compare June 10, 2025 16:54
@remyleone remyleone added this pull request to the merge queue Jun 12, 2025
Merged via the queue into scaleway:main with commit 5d62b58 Jun 12, 2025
17 of 20 checks passed
@Mia-Cross Mia-Cross deleted the vpc_fix_switch_to_v2 branch June 12, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants