Allow JSONL for fine-tuning datasets #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +53,7 @@ def ensure_model_name_is_valid_k8s_label(model_name: str): | |||
| def read_csv_headers(file_location: str): | |||
There was a problem hiding this comment.
update the function name that it now loads other file formats?
There was a problem hiding this comment.
Hm I think this function name is still accurate because it treats all files as CSVs, even when they're not? 😛
yunfeng-scale
approved these changes
Apr 9, 2024
saiatmakuri
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Change gateway validation for fine-tuning datasets: allow JSONL format, and the column names
inputandoutputTest Plan and Usage Guide
Test deployment