Add emitted timestamp for logging #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiatmakuri
approved these changes
Feb 23, 2024
| @@ -122,6 +124,7 @@ def handle( | |||
| return | |||
| response["task_id"] = task_id | |||
| data_record = { | |||
| "EMITTED_AT": datetime.now(pytz.timezone("US/Pacific")).strftime("%Y-%m-%dT%H:%M:%S"), | |||
There was a problem hiding this comment.
nit: should be a UTC timestamp so there's no timezone or daylight saving time information baked into the dates here
There was a problem hiding this comment.
i'm fine with using UTC but seems like we're using PST elsewhere in the codebase?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Logs emitted at timestamp for logging.
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.