add support for mixtral-8x7b and mixtral-8x7b-instruct #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-scale
reviewed
Dec 12, 2023
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
| @@ -58,6 +58,8 @@ def get_default_supported_models_info() -> Dict[str, ModelInfo]: | |||
| ), | |||
| "mistral-7b": ModelInfo("mistralai/Mistral-7B-v0.1", None), | |||
| "mistral-7b-instruct": ModelInfo("mistralai/Mistral-7B-Instruct-v0.1", None), | |||
There was a problem hiding this comment.
let's also update mistral-7b-Instruct to use the newer version released today: https://huggingface.co/mistralai/Mistral-7B-Instruct-v0.2 we can do this in a follow up pr but good to do as well
There was a problem hiding this comment.
should we add it as a separate model instead of replacing the current one? also, should do that as a follow-up PR
There was a problem hiding this comment.
Personally I wouldn't make it a separate model, I would just add the weights to s3 and use them in favor of the v0.1 weights. I suppose there is some value to having both models though for completeness, @yunfeng-scale thoughts on this?
There was a problem hiding this comment.
don't think there's need to add as a new model
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
yunfeng-scale
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
bump vllm to v0.2.4 to support mixtral-8x7b models
Test Plan and Usage Guide
spin up model for local inference