Skip to content

Change DATADOG_TRACE_ENABLED to DD_TRACE_ENABLED #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

Change DATADOG_TRACE_ENABLED to DD_TRACE_ENABLED #350

merged 1 commit into from
Oct 25, 2023

Conversation

edwardpark97
Copy link
Contributor

image confirmed that setting DATADOG_TRACE_ENABLED=false in a pod does nothing, but setting DD_TRACE_ENABLED=false in a pod successfully turns off datadog logging

@edwardpark97 edwardpark97 merged commit 2603b9b into main Oct 25, 2023
@edwardpark97 edwardpark97 deleted the datadog_enabled branch October 25, 2023 16:57
@yunfeng-scale yunfeng-scale mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yunfeng-scale yunfeng-scale yunfeng-scale approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardpark97 @yunfeng-scale