Skip to content

Various changes/bugfixes to chart/code to streamline deployment on different forms of infra #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 2, 2023
Merged

Various changes/bugfixes to chart/code to streamline deployment on different forms of infra #339

merged 24 commits into from
Nov 2, 2023

Conversation

seanshi-scale
Copy link
Contributor

@seanshi-scale seanshi-scale commented Oct 20, 2023 •
edited
Loading

  • Add DB_SECRET_AWS_PROFILE to templates, this is needed in the db init job
  • Allow db init job to be run even if you're reading dbcreds from an AWS secret
  • Allow optionally creating image builder + inference serviceaccounts
  • Parametrize some ECR repo names in the endpoint builder
  • Allow the refresh codeartifact creds script to not run if the script isn't there
  • Fix a bug with initializing the k8s autoscaling client

Test: installed in a separate VPC

@seanshi-scale seanshi-scale changed the title Seanshi/231019 helm chart improvements Various changes/bugfixes to chart/code to streamline deployment on different forms of infra Oct 24, 2023
@seanshi-scale seanshi-scale self-assigned this Nov 1, 2023
@seanshi-scale seanshi-scale marked this pull request as ready for review November 1, 2023 20:57
@seanshi-scale seanshi-scale enabled auto-merge (squash) November 2, 2023 20:01
@seanshi-scale seanshi-scale merged commit f3118a6 into main Nov 2, 2023
@seanshi-scale seanshi-scale deleted the seanshi/231019-helm-chart-improvements branch November 2, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@song-william song-william Awaiting requested review from song-william

1 more reviewer

@yunfeng-scale yunfeng-scale yunfeng-scale approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@seanshi-scale seanshi-scale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanshi-scale @yunfeng-scale