Validate quantization #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixu34
reviewed
Oct 10, 2023
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
yunfeng-scale
commented
Oct 10, 2023
| @@ -73,5 +74,5 @@ def get_boolean_env_var(name: str) -> bool: | |||
| logger.warning("LOCAL development & testing mode is ON") | |||
|
|
|||
| GIT_TAG: str = os.environ.get("GIT_TAG", "GIT_TAG_NOT_FOUND") | |||
| if GIT_TAG == "GIT_TAG_NOT_FOUND": | |||
| if GIT_TAG == "GIT_TAG_NOT_FOUND" and "pytest" not in sys.modules: | |||
There was a problem hiding this comment.
make pytest work without specifying GIT_TAG
ian-scale
approved these changes
Oct 11, 2023
| LLMInferenceFramework.DEEPSPEED: [], | ||
| LLMInferenceFramework.TEXT_GENERATION_INFERENCE: [Quantization.BITSANDBYTES], | ||
| LLMInferenceFramework.VLLM: [Quantization.AWQ], | ||
| LLMInferenceFramework.LIGHTLLM: [], |
There was a problem hiding this comment.
probably best for a separate pr, but can you update the docs to specify which models in the model zoo support lightllm as inference framework?
saiatmakuri
reviewed
Oct 11, 2023
| ) | ||
| if num_shards > gpus: | ||
| raise ObjectHasInvalidValueException( | ||
| f"Num shard {num_shards} must be less than or equal to the number of GPUs {gpus}." |
There was a problem hiding this comment.
nit: could mention the inference framework in the error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate quantization values when creating endpoints