Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ jobs:
# cmd.
# Keep the sbt version in sync with `sbt-ci-release.bat`.
run: |
sbt -sbt-version 1.6.2 version
sbt -sbt-version 1.7.2 version
shell: bash
- name: Publish GraalVM Native artifacts
run: >-
Expand Down
2 changes: 1 addition & 1 deletion backend/src/main/scala/bloop/reporter/Reporter.scala
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ abstract class Reporter(
case _ =>
val mappedPos = p.position
val problemID = if (p.position.sourceFile.isPresent) nextID() else -1
Problem(problemID, p.severity, p.message, mappedPos, p.category)
Problem(problemID, p.severity, p.message, mappedPos, p.category, p.diagnosticCode())
}
}

Expand Down
2 changes: 1 addition & 1 deletion bin/sbt-ci-release.bat
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Rem Keep ci.yaml in sync with the sbt version
sbt -sbt-version 1.6.2 bloopgun/graalvm-native-image:packageBin
sbt -sbt-version 1.7.2 bloopgun/graalvm-native-image:packageBin
4 changes: 2 additions & 2 deletions frontend/src/main/scala/bloop/logging/BspServerLogger.scala
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ final class BspServerLogger private (
val problemPos = event.problem.position
val problemSeverity = event.problem.severity
val sourceFile = toOption(problemPos.sourceFile())
// TODO: Add code content
val code = toOption(event.problem.diagnosticCode()).map(_.code())

(problemPos, sourceFile) match {
case (ZincInternals.ZincExistsStartPos(startLine, startColumn), Some(file)) =>
Expand All @@ -120,7 +120,7 @@ final class BspServerLogger private (
val source = Some("bloop")
val uri = bsp.Uri(file.toPath.toUri)
val severity = bspSeverity(problemSeverity)
val diagnostic = bsp.Diagnostic(pos, Some(severity), None, source, message, None)
val diagnostic = bsp.Diagnostic(pos, Some(severity), code, source, message, None)
val textDocument = bsp.TextDocumentIdentifier(uri)
val buildTargetId = bsp.BuildTargetIdentifier(event.projectUri)
client.notify(
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
2 changes: 1 addition & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ object Dependencies {
val nailgunCommit = "a2520c1e"

// Keep in sync in BloopComponentCompiler
val zincVersion = "1.6.0"
val zincVersion = "1.7.2"

val bspVersion = "2.0.0"
val javaDebugVersion = "0.21.0+1-7f1080f1"
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.6.2
sbt.version=1.7.2
15 changes: 13 additions & 2 deletions shared/src/main/scala/bloop/reporter/Problem.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package bloop.reporter

import java.util.Optional

import xsbti.Severity

/** Describes a problem (error, warning, message, etc.) given to the reporter. */
Expand All @@ -13,12 +15,21 @@ final case class Problem private (
/** Position in the source code where the message was triggered */
position: xsbti.Position,
/** The category of this problem. */
category: String
category: String,
/** Unique code attatched to the diagnostic being reported */
override val diagnosticCode: Optional[xsbti.DiagnosticCode]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override val here is odd but I believe it's needed because of the signature in Javaland. Is there a better way to do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

) extends xsbti.Problem

object Problem {
def fromZincProblem(problem: xsbti.Problem): Problem = {
Problem(-1, problem.severity(), problem.message(), problem.position(), problem.category())
Problem(
-1,
problem.severity(),
problem.message(),
problem.position(),
problem.category(),
problem.diagnosticCode()
)
}

case class DiagnosticsCount(errors: Long, warnings: Long) {
Expand Down