Skip to content

Fix inline docs #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 7, 2019
Merged

Fix inline docs #6619

merged 8 commits into from
Jun 7, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 6, 2019

A PR to work together on the inline docs.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

odersky and others added 3 commits June 6, 2019 15:15
- Remove inline-logging as it was already existing
- Adjust text for inlining
- Add all examples in the reference
- Various fixes around
@odersky
Copy link
Contributor Author

odersky commented Jun 6, 2019

@aggelos I pushed fixes to the rest of inline.md.

One more thing to do: "erased terms" should go into the meta programming section. We should have a new toc entry for this also.

@odersky
Copy link
Contributor Author

odersky commented Jun 6, 2019

@nicolasstucki Can you also go over macros.md, and the following pages to verify that everything is up to date?

@odersky odersky force-pushed the fix-inline-docs branch from 5bc4659 to 674451f Compare June 6, 2019 16:48
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Aggelos Biboudis and others added 2 commits June 7, 2019 14:03
Co-Authored-By: Nicolas Stucki <[email protected]>
… encoding as an alternative encoding for comparison- add an implicit match port of the state machine as a test case
@biboudis biboudis merged commit 78cd1db into scala:master Jun 7, 2019
@biboudis biboudis deleted the fix-inline-docs branch June 7, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants