fix: simplify infer type for apply #23434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
infer-type-for-apply
branch
from
3dd303b to
44366a0
Compare
kasiaMarek
changed the title
tgodzik
approved these changes
Jun 30, 2025
| yield tpe | ||
| case Some(tpe) => Some(tpe) | ||
| case _ => None | ||
| val idx = app.args.indexWhere(_.span.contains(span)) |
There was a problem hiding this comment.
Och wow, that is much simpler!
|
Thanks, looking forward to it being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: scalameta/metals#7538
fixes: scalameta/metals#7564
fixes: scalameta/metals#7567
I made the change, so infer type would reuse signature help.Actually there was a way simpler way to do this.