Skip to content

Enable -Ycheck-init on community projects and CI #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 25, 2021
Merged

Enable -Ycheck-init on community projects and CI #11385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fbff070
Remove unused file
liufengyun Nov 27, 2020
081aa78
Refactor check
liufengyun Nov 27, 2020
93a8184
Fix debugging code
liufengyun Nov 28, 2020
e3de5ac
Don't produce duplicate select effect in potential expansion
liufengyun Nov 28, 2020
7910e35
Revert #9673
liufengyun Nov 29, 2020
322f4d0
check initialization in community build
liufengyun Dec 3, 2020
7f03121
Use correct owner for summarizing effects in parent calls
liufengyun Dec 4, 2020
1b20194
Fix crash: ensure class type is applied
liufengyun Dec 4, 2020
8ed8887
Fix stdlib CB: don't check language patches
liufengyun Dec 4, 2020
500083c
Suppress warning in shapeless
liufengyun Dec 4, 2020
16c8bfa
Restore tests
liufengyun Dec 4, 2020
91c0f56
Fix CI: ignore export clause
liufengyun Dec 4, 2020
0f034aa
Set defTree properly
liufengyun Feb 12, 2021
e4efda8
Disable -Ycheck-init for cats due to -Xfatal-warnings
liufengyun Feb 12, 2021
3a6b0c8
Address review
liufengyun Feb 16, 2021
db19f60
Revert changes to shapeless
liufengyun Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,17 @@ final case class SbtCommunityProject(
extraSbtArgs: List[String] = Nil,
dependencies: List[CommunityProject] = Nil,
sbtPublishCommand: String = null,
sbtDocCommand: String = null
sbtDocCommand: String = null,
scalacOptions: List[String] = List("-Ycheck-init")
) extends CommunityProject:
override val binaryName: String = "sbt"

private def scalacOptionsString: String =
scalacOptions.map("\"" + _ + "\"").mkString("List(", ",", ")")

private val baseCommand =
"clean; set logLevel in Global := Level.Error; set updateOptions in Global ~= (_.withLatestSnapshots(false)); "
++ (if scalacOptions.isEmpty then "" else s"""set scalacOptions in Global ++= $scalacOptionsString;""")
++ s"++$compilerVersion!; "

override val testCommand =
Expand Down Expand Up @@ -307,7 +312,8 @@ object projects:
lazy val shapeless = SbtCommunityProject(
project = "shapeless",
sbtTestCommand = "test",
sbtDocCommand = forceDoc("typeable", "deriving", "data")
sbtDocCommand = forceDoc("typeable", "deriving", "data"),
scalacOptions = Nil // disable -Ycheck-init, due to -Xfatal-warnings
)

lazy val xmlInterpolator = SbtCommunityProject(
Expand Down Expand Up @@ -466,7 +472,8 @@ object projects:
project = "discipline-specs2",
sbtTestCommand = "test",
sbtPublishCommand = "coreJVM/publishLocal;coreJS/publishLocal",
dependencies = List(discipline)
dependencies = List(discipline),
scalacOptions = Nil // disable -Ycheck-init
)

lazy val simulacrumScalafixAnnotations = SbtCommunityProject(
Expand All @@ -479,7 +486,8 @@ object projects:
project = "cats",
sbtTestCommand = "set scalaJSStage in Global := FastOptStage;buildJVM;validateAllJS",
sbtPublishCommand = "catsJVM/publishLocal;catsJS/publishLocal",
dependencies = List(discipline, disciplineMunit, scalacheck, simulacrumScalafixAnnotations)
dependencies = List(discipline, disciplineMunit, scalacheck, simulacrumScalafixAnnotations),
scalacOptions = Nil // disable -Ycheck-init, due to -Xfatal-warning
)

lazy val catsMtl = SbtCommunityProject(
Expand Down
3 changes: 2 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/init/Checker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import ast.tpd
import dotty.tools.dotc.core._
import Contexts._
import Types._
import Symbols._

import dotty.tools.dotc.transform._
import MegaPhase._
Expand Down Expand Up @@ -45,7 +46,7 @@ class Checker extends MiniPhase {
}

// A concrete class may not be instantiated if the self type is not satisfied
if (instantiable) {
if (instantiable && cls.enclosingPackageClass != defn.StdLibPatchesPackage.moduleClass) {
implicit val state: Checking.State = Checking.State(
visited = Set.empty,
path = Vector.empty,
Expand Down
Loading