GSoC 2022 Report Article #1432
Merged
GSoC 2022 Report Article #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone involved, if you have a minute, please review: |
|
Hi, I'm glad to see this writeup! I think this line should be changed:
Doodle Explore isn't a GUI, it's a specification for an eDSL that allows artists to create GUIs. Should I make a PR? |
|
LGTM |
bjaglin
reviewed
Nov 1, 2022
rvacaru
reviewed
Nov 1, 2022
julienrf
requested changes
Nov 2, 2022
|
LGTM |
anatoliykmetyuk
commented
Nov 2, 2022
noelwelsh
approved these changes
Nov 2, 2022
|
I've added a suggestion but add your own if you don't like my wording.
…On Tue, Nov 1, 2022 at 5:46 PM Mikail Khan ***@***.***> wrote:
Hi, I'm glad to see this writeup! I think this line should be changed:
Mikail Khan, mentored by Noel Welsh, developed such a GUI during the
Summer of 2022
Doodle Explore isn't a GUI, it's a specification for an eDSL that allows
artists to create GUIs. Should I make a PR?
—
Reply to this email directly, view it on GitHub
<#1432 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH5XGPET3FMC2PXOY3KWLWGFJN7ANCNFSM6AAAAAARUGAQQQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tgodzik
reviewed
Nov 2, 2022
tgodzik
approved these changes
Nov 2, 2022
|
Looks good, thanks again |
Co-authored-by: Brice Jaglin <[email protected]>
Co-authored-by: Brice Jaglin <[email protected]>
Co-authored-by: Brice Jaglin <[email protected]>
Co-authored-by: Brice Jaglin <[email protected]>
Co-authored-by: Julien Richard-Foy <[email protected]>
Co-authored-by: Noel Welsh <[email protected]>
Co-authored-by: Tomasz Godzik <[email protected]>
bjaglin
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Thanks @anatoliykmetyuk for coordinating the participation to the program!
Co-authored-by: Brice Jaglin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.