Skip to content

downgrade sbt-native-packager to 0.6.4 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2016

Conversation

SethTisue
Copy link
Member

this restores the 2.11.7 status quo for the 2.11.8 release.
see commit comments for further details

review by @adriaanm, cc @muuki88

this restores the 2.11.7 status quo for the 2.11.8 release.

the upgrade turned out to be way too problematic.  even after multiple
PRs addressing regressions, new ones continue to turn up; see
scala/scala-dev#92 for details on the latest
regressions. for past history (including details on regressions), see
these PRs in this repo: scala#159, scala#157, scala#156, scala#155, scala#154, scala#142, plus issue

so what's next after this?

- we could maybe still consider upgrading for 2.11.9, but someone
  would need to thoroughly QA it on all platforms and assure us there
  are no regressions

- or we could restrict the upgrade to 2.12.x and hope for
  partially crowdsourced QA so that regressions would be caught
  during the milestone and release candidate phases.

I lean towards leaving 2.11.x frozen at 0.6.4, at least unless the
upgrade brings concrete benefits to end users (no one has listed
any, to my knowledge).  if this is mainly just dogfooding, then
2.12.x is a better context for that.
@SethTisue SethTisue self-assigned this Mar 3, 2016
@SethTisue SethTisue added this to the 2.11.8 milestone Mar 3, 2016
@muuki88
Copy link
Contributor

muuki88 commented Mar 3, 2016

@SethTisue sorry for the inconvenience :(
If I have time, I'll we can fix some of the problems in native-packager.

@SethTisue
Copy link
Member Author

sorry for the inconvenience

np, none of the work is wasted if we can get it into 2.12 instead

@SethTisue SethTisue force-pushed the native-packager-downgrade branch from f36a5cd to 23d097e Compare March 3, 2016 17:15
@muuki88
Copy link
Contributor

muuki88 commented Mar 3, 2016

@SethTisue off-topic: do we have to change the vendor for sbt-native-packager as well?

@SethTisue
Copy link
Member Author

do we have to change the vendor for sbt-native-packager as well

@muuki88 is there a reason not to? I don't know what implications the vendor setting has, I just sort of assumed it was a string that might show up in UIs somewhere

@muuki88
Copy link
Contributor

muuki88 commented Mar 3, 2016

sorry, by vendor I meant the artifact groupid (com.typesafe.sbt)

@SethTisue
Copy link
Member Author

well, in general, the thinking at Lightbend is that there's no big rush to make com.typesafe -> com.lightbend changes to group ids and such and the changes should be timed to coincide with big version bumps, so people will be needing to make changes anyway and won't mind one more

but sbt stuff specifically, I don't know, you'd have to ask the sbt folks

SethTisue added a commit that referenced this pull request Mar 4, 2016
downgrade sbt-native-packager to 0.6.4
@SethTisue SethTisue merged commit eaa386b into scala:2.11.x Mar 4, 2016
@SethTisue SethTisue deleted the native-packager-downgrade branch March 4, 2016 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants