Skip to content

Reduce logging overhead and minor cleanups #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2017
Merged

Reduce logging overhead and minor cleanups #172

merged 1 commit into from
Jun 23, 2017

Conversation

rorygraves
Copy link
Contributor

@rorygraves rorygraves commented Jun 21, 2017 •
edited
Loading

The logging even when disabled was doing (the default case) was doing a significant amount of work (esp the logDiagnostics parametersl).

Also AsyncUtils.verbose and AsyncUtils.debug were computed on every call.

The result of the changes are minor cleanups seen along the way.

retronym
retronym approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@retronym retronym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Rory, all LGTM.

@retronym retronym merged commit c5e701a into scala:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retronym retronym retronym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rorygraves @retronym