Skip to content

Windows 2025 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eed3si9n merged 2 commits into from
Aug 19, 2025
Merged

Windows 2025 #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e7a85
Windows 2025
eed3si9n Aug 19, 2025
77ae3b6
Revert "Mark a test pending"
eed3si9n Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
java: 11
distribution: temurin
jobtype: 2
- os: windows-latest
- os: windows-2025
java: 8
distribution: zulu
jobtype: 3
Expand Down
43 changes: 18 additions & 25 deletions io/src/test/scala/sbt/internal/io/SourceModificationWatchSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,21 +97,16 @@ private[sbt] trait EventMonitorSpec { self: AnyFlatSpec & Matchers =>

it should "ignore creation of files that are explicitly ignored" in IO
.withTemporaryDirectory { dir =>
// TODO https://github.com/sbt/io/issues/434
if (scala.util.Properties.isWin) {
pending
} else {
val parentDir = dir / "src" / "watchme"
val created = parentDir / ".hidden.scala"
val notIgnored = parentDir / "foo.scala"
val parentDir = dir / "src" / "watchme"
val created = parentDir / ".hidden.scala"
val notIgnored = parentDir / "foo.scala"

IO.createDirectory(parentDir)
IO.createDirectory(parentDir)

assert(watchTest(parentDir, AllPass, excludes(created.toPath)) {
randomTouch(created)
randomTouch(notIgnored)
})
}
assert(watchTest(parentDir, AllPass, excludes(created.toPath)) {
randomTouch(created)
randomTouch(notIgnored)
})
}

it should "ignore creation of an empty directory" in IO.withTemporaryDirectory { dir =>
Expand Down Expand Up @@ -196,20 +191,18 @@ private[sbt] trait EventMonitorSpec { self: AnyFlatSpec & Matchers =>

it should "ignore deletion of files not included in inclusion filter" in IO
.withTemporaryDirectory { dir =>
// TODO https://github.com/sbt/io/issues/434
if (scala.util.Properties.isWin) {
pending
} else {
val parentDir = dir / "src" / "watchme"
val file = parentDir / "inme"
IO.write(file, "foo")
val source = parentDir / "foo.scala"

assert(watchTest(parentDir, AllPass, excludes(file.toPath)) {
IO.delete(file)
randomTouch(source)
})
pending // TODO
}
val parentDir = dir / "src" / "watchme"
val file = parentDir / "inme"
IO.write(file, "foo")
val source = parentDir / "foo.scala"

assert(watchTest(parentDir, AllPass, excludes(file.toPath)) {
IO.delete(file)
randomTouch(source)
})
}

it should "ignore deletion of files explicitly ignored" in IO.withTemporaryDirectory { dir =>
Expand Down
Loading