Skip to content

Make socksify and rack gem dependencies optional #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olleolleolle merged 1 commit into from
Oct 5, 2021
Merged

Make socksify and rack gem dependencies optional #225

olleolleolle merged 1 commit into from
Oct 5, 2021

Conversation

@ioquatix
Copy link
Contributor

@ioquatix ioquatix commented Oct 5, 2021 •
edited
Loading

Fixes #224. Fixes #205.

@ioquatix ioquatix force-pushed the update-and-rework-gem-dependencies branch 2 times, most recently from 9e25a26 to 650b037 Compare October 5, 2021 07:05
olleolleolle
olleolleolle reviewed Oct 5, 2021
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ioquatix ioquatix force-pushed the update-and-rework-gem-dependencies branch from 83f391e to 2ed09a9 Compare October 5, 2021 11:14
@olleolleolle
Copy link
Contributor

olleolleolle commented Oct 5, 2021

I am frantically pushing APPROVE AND RUN

@ioquatix ioquatix force-pushed the update-and-rework-gem-dependencies branch 5 times, most recently from 8f41b40 to e9057fd Compare October 5, 2021 12:08
olleolleolle
olleolleolle reviewed Oct 5, 2021
View reviewed changes
olleolleolle
olleolleolle reviewed Oct 5, 2021
View reviewed changes
spec/httpi/httpi_spec.rb

HTTPI::Adapter::ADAPTERS.each do |adapter, opts|
unless (adapter == :em_http && RUBY_VERSION =~ /1\.8/) || (adapter == :curb && RUBY_PLATFORM =~ /java/)
unless (adapter == :em_http || adapter == :curb) && RUBY_PLATFORM =~ /java/
Copy link
Contributor

@olleolleolle olleolleolle Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, a platform-to-adapters-supported-on-that-platform could be interesting.

Copy link
Contributor Author

@ioquatix ioquatix Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was a quick hack to get it passing since it's already 1AM lol.

Copy link
Contributor

@olleolleolle olleolleolle Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in due time, that's a note for future PRs.

Copy link

@Gobombers Gobombers Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link

@Gobombers Gobombers Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@olleolleolle
Copy link
Contributor

olleolleolle commented Oct 5, 2021

So, I think this is at the place where we need to look at things we can extract from it, and offer to the default branch.

A way forward with this big a change is a new major version, which allows to shed old version support etc.

@olleolleolle olleolleolle linked an issue Oct 5, 2021 that may be closed by this pull request
CI stopped on Travis #222
Closed
@olleolleolle
Copy link
Contributor

olleolleolle commented Oct 5, 2021

In addition to the earlier things fixed, the CI issue is also fixed by this.

@olleolleolle olleolleolle mentioned this pull request Oct 5, 2021
Closed
3 tasks
@ioquatix ioquatix force-pushed the update-and-rework-gem-dependencies branch from a797a27 to e777d2f Compare October 5, 2021 12:50
@olleolleolle olleolleolle changed the title Remove socksify and rack gem dependencies. Update puma and rake. Make socksify and rack gem dependencies optional Oct 5, 2021
@olleolleolle olleolleolle merged commit ac93ad6 into savonrb:master Oct 5, 2021
olleolleolle added a commit that referenced this pull request Oct 5, 2021
@olleolleolle
CHANGELOG: Note about #225
772e678
@ioquatix ioquatix deleted the update-and-rework-gem-dependencies branch October 5, 2021 13:13
@pcai
Copy link
Member

pcai commented Oct 5, 2021

Thank you for your work on this.

@olleolleolle
Copy link
Contributor

olleolleolle commented Oct 18, 2021

This has now been released as 3.0.0. https://github.com/savonrb/httpi/releases/tag/v3.0.0

@ioquatix
Copy link
Contributor Author

ioquatix commented Oct 18, 2021

Thank you so much.

@moenodedev moenodedev mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

+1 more reviewer

@Gobombers Gobombers Gobombers left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can we remove socksify as a dependency? CI stopped on Travis Licence issue with Socksify gem

4 participants

@ioquatix @olleolleolle @pcai @Gobombers