Add SSL min/max_version configuration for supporting adapters #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpasquini
force-pushed
the
ssl_min_max_version
branch
from
260d8d2 to
3183c55
Compare
rogerleite
requested changes
Jul 7, 2020
Member
rogerleite
left a comment
rogerleite
left a comment
There was a problem hiding this comment.
Hey @mrpasquini
Thanks for the PR. I didn't know about this deprecation.
I think the PR is good, I just put some comments to improve usability.
mrpasquini
force-pushed
the
ssl_min_max_version
branch
from
3183c55 to
a4d906c
Compare
Contributor
Author
|
Thank you for the suggestions. I have incorporated them and updated the related tests to check for the new errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl_versionis deprecated and only provided for backwards compatibility. Documentation says to usemin_version=andmax_version=instead.This PR adds support for these configuration options for the adapters that support them.
HTTPI::NotImplementedErrorare raised for Curb and HttpClient that do not support these configuration options.A new static
HTTPI::SSL::MIN_MAX_VERSIONSis introduced to list the supported verions for min/max_verions. This is different thanHTTPI::SSL::SSL_VERSIONSas the ssl_version value would beTLSv1_2where the min/max_version value isTLS1_2