Main bmg #1
Merged
Main bmg #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(mobile): first video memory doesn't play * refactor: moved logic to static method * refactor: fix haptic feedback & empty check * refactor: use DriftMemory on setMemory * refactor: move video reset into if block
* fix: use npm instead of pnpm and fix `check:all` * fix: remove `--` from pnpm commands * Remove `check:all` from the documentation section
…arams (immich-app#23333) Co-authored-by: Greg Lutostanski <[email protected]> Co-authored-by: Alex <[email protected]>
* fix: incorrect updatedAt value in local assets * add test --------- Co-authored-by: shenlong-tanwen <[email protected]>
fix: getExif fallback to db width and height Co-authored-by: shenlong-tanwen <[email protected]>
* fix(web): fix support & feedback modal wrapping * Fix reference
…app#23903) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…pp#23901) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Dietzler <[email protected]>
…roup and split into AssetLayout and Month components (immich-app#23338) * refactor(web): Extract asset grid layout component from TimelineDateGroup and split into AssetLayout and Month components * chore: cleanup --------- Co-authored-by: Daniel Dietzler <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#24162) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…p#24164) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix: sidecar check job * feat: move sidecars to asset_files * feat: combine with handleSidecarCheck * fix(server): improved method signatures for stack and sidecar copying * fix(server): improved method signatures for stack and sidecar copying * chore: clean up --------- Co-authored-by: Jason Rasmussen <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore-change-workflow-column-name
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Dietzler <[email protected]>
* do not delete isOffline assets * update sql * add medium test * add normal delete test * formatting
fix: exposure info and better readabilit
Adjust the zoom level
Prevent OOM on reverse proxy servers Added configuration to disable buffering for uploads.
Description ----------- The documentation lies about comments in `docker/docker-compose.dev.yml`. Reason: in 689c6aa these docs were added but the comments in this file are removed in b9e2590 and the docs weren't updated. How Has This Been Tested? ------------------------- ``` $ git log -S rootless commit b9e2590 Author: Jason Rasmussen <[email protected]> Date: Tue Sep 16 12:48:44 2025 -0400 chore: simplify (immich-app#22082) commit 689c6aa Author: Rudolf Horváth <[email protected]> Date: Thu Nov 21 13:25:45 2024 +0100 docs: add developer notes about rootless docker setup (immich-app#13250) ``` Checklist: ---------- - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
* use adjustment time in iOS for hash reset * migration * fix equals check --------- Co-authored-by: shenlong-tanwen <[email protected]>
* feat(web): search type selection dropdown * chore: implement suggestions * lint --------- Co-authored-by: Alex <[email protected]>
Description ----------- When I follow the [developer setup](https://docs.immich.app/developer/setup) I run into a permission error using rootless docker. A while ago I asked on Discord in [#contributing](https://discord.com/channels/979116623879368755/1071165397228855327/1442974448776122592) about these ulimits. I suggest to remove the `ulimits` altogether. It seems that @ItalyPaleAle has left the setting just hoping that it could help somebody in the future. See the [PR description](immich-app#4556). How Has This Been Tested? ------------------------- Using rootless docker: ``` $ docker context ls NAME DESCRIPTION DOCKER ENDPOINT ERROR default unix:///var/run/docker.sock rootless * unix:///run/user/1000/docker.sock ``` Running `make` will fail because of permission errors: ``` $ docker compose -f ./docker/docker-compose.dev.yml up --remove-orphans ... Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error setting rlimits for ready process: error setting rlimit type 7: operation not permitted ``` On my machine I have the following hard limit for "Maximum number of open file descriptors": ``` $ ulimit -nH 524288 ``` I can confirm that the permission error is caused by the security restrictions of the operating system mentioned above: Changing `docker/docker-compose.dev.yml` like .. ``` ulimits: nofile: soft: 524289 hard: 524289 ``` .. will lead to a permission error whereas this .. ``` ulimits: nofile: soft: 524288 hard: 524288 ``` .. starts fine. Apparently the defaults for these limits are coming from [systemd](https://github.com/systemd/systemd/blob/26b2085d54ebbfca8637362eafcb4a8e3faf832f/man/systemd.exec.xml#L1122) which is used on nearly every linux distribution. So my assumption is that almost any linux user who uses rootless docker will run into a permission error when starting the development setup. Checklist: ---------- - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable - [x] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`)
allows the tab pages to use the standard Material page transition during push/pop navigation
# Conflicts: # machine-learning/Dockerfile # machine-learning/immich_ml/models/ocr/detection.py # machine-learning/patches/0002-target-gfx900-gfx1102.patch # machine-learning/uv.lock
|
Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label. |
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
...