Should libsass have an image-url function?

[michaek]

See

libsass/functions.cpp

Line 1179 in fca1f75

Signature image_url_sig = "image-url($path, $only-path: false, $cache-buster: false)";

Because image-url is a Compass function, not a Sass function, it seems odd for it to be included in libsass. Building in any URL functions requires "Sass" to know about your paths - Compass has embraced that pattern, but I don't know if we should assume that Sass does.

[HamptonMakes]

Hmm... yeah, I don't think we can properly implement URL parsing in C++... without incurring a lot of overhead. I think host languages should be able to include it when we get custom functions in.

[nschonni]

👍 the longer this stays in the libarary, the more people that will start using it and making it more painful to remove from the API

[akhleung]

Alas, my employer (who sponsored the initial development of LibSass) needs it, which is why it's in there....

[HamptonMakes]

@akhleung couldn't you use the custom function compilation interface to implement this just for the moovweb gosass?

[akhleung]

@hcatlin Yeah, that would be the proper thing to do ... image-url was added early in LibSass's life cycle because we were using it all over the place.

[nschonni]

@hcatlin I think this needs to go in the 3.0 release since it is a breaking API change