Make reponse format JSONSchema optional #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This morning's PR #813 makes it impossible to do ChatCompletionRequest that doesn't supply a json schema.
Describe your solution
I followed the suggestion in #818, changing the JSONSchema attached to a request format object to a pointer type, so that the JSON marshaler can properly exclude it when not provided.
Tests
I ran the go tests. (did you guys know you have a bunch of broken tests in the repo?)
All tests pass except for the ones in the jsonschema directory. Those tests were broken both before and after my changes.
I updated my own software to use my fork, and everything works.
Issue: #818