Configurable Transport #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for that PR! It made me think about how we want to approach client initialization — there was a great article about different ways of doing that, but I could not find it. The closest is this one: https://asankov.dev/blog/2022/01/29/different-ways-to-initialize-go-structs/ I don't think the usage of client := gogpt.NewClient()
// or
config := gogpt.DefaultConfig()
config.Transport = retryablehttp.NewClient().StandardClient()
client := gogpt.NewClientWithConfig(config)@mwillfox would you have the bandwidth to do such a refactoring? It's totally cool if not — I can do it in a follow-up PR. |
|
I should have time to refactor in the next few days and I'll update the PR. Thanks for the feedback! |
|
Will follow up this work in a |
Merged
sashabaranov
added a commit
that referenced
this pull request
Feb 20, 2023
* Configurable Transport (#75) * new functions to allow HTTPClient configuration * updated go.mod for testing from remote * updated go.mod for remote testing * revert go.mod replace directives * Fixed NewOrgClientWithTransport comment * Make client fully configurable * make empty messages limit configurable #70 #71 * make auth token private in config * add docs * lint --------- Co-authored-by: Michael Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking changes which allow for a configurable "Transport" (language which was already used in the project, really a
*http.Client).This allows for setting a custom
RoundTripperor usingmygithub.libinneed.workers.dev/hashicorp/go-retryablehttp:With the recent stability issues and load of the OpenAI API this is necessary to use the module in a production environment.