fix(init): fix unattended mode flags for --no-git, --missing, and --bare#903
Open
fix(init): fix unattended mode flags for --no-git, --missing, and --bare#903
Conversation
|
Claude finished @binoy14's task in 1m 21s —— View job ReviewThe three code fixes are correct. One issue to address: Changeset summary is misleading and too long ( The summary says "Fixed init command unattended mode: ..." but the The summary is also compound (three fixes in one sentence), making it harder to parse. Suggested replacement: |
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (289b390) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.95 MB | - |
| Bundled (gzip) | 2.06 MB | - |
| Import time | 842ms | -4ms, -0.4% |
bin:sanity
| Metric | Value | vs main (289b390) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 1.97s | -35ms, -1.7% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (289b3904)
| Metric | Value | vs main (289b390) |
|---|---|---|
| Internal (raw) | 92.3 KB | - |
| Internal (gzip) | 21.6 KB | - |
| Bundled (raw) | 21.53 MB | - |
| Bundled (gzip) | 3.41 MB | - |
| Import time | 798ms | +2ms, +0.3% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (289b3904)
| Metric | Value | vs main (289b390) |
|---|---|---|
| Internal (raw) | 976 B | - |
| Internal (gzip) | 507 B | - |
| Bundled (raw) | 50.7 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
227a535 to
e0d0401
Compare
Contributor
Coverage Delta
Comparing 1 changed file against main @ Overall Coverage
|
- Respect --no-git flag when determining whether to initialize git - Pass --missing to dataset import to avoid errors when dataset exists - Allow --bare mode without requiring --output-path in unattended mode Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
06e846b to
8f4d78a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-gitflag when determining whether to initialize git repository--missingto dataset import to avoid errors when dataset already exists--baremode without requiring--output-pathin unattended modeThese bugs also existed in the original CLI (sanity-labs/sanity-old-cli-bkp) — they are not regressions from the migration.
Test plan
--no-gitskips git initialization--no-gitis not passed--import-datasetasserts--missingis included in args--barein unattended mode does not require--output-pathNotes for Release
Fixed
--no-gitflag being ignored during git initialization,--missingnot being passed to dataset import, and--bareincorrectly requiring--output-pathin unattended mode.🤖 Generated with Claude Code