refactor(init): move init logic to action pattern by binoy14 · Pull Request #845 · sanity-io/cli

binoy14 · 2026-03-30T21:55:22Z

refactor(init): move init logic to action pattern (#748)

refactor(init): split init flows into separate functions (#753)

claude · 2026-03-30T21:55:41Z

Claude finished @binoy14's task in 5m 9s —— View job

Review

Gather context
Read changed files
Check for changeset
Post review

Changeset: Not present. This is a pure refactor with no observable behavioral change to any public CLI API — no changeset required. ✓

`initAction.ts:790` — dead `schemaUrl` field in return type

}> {
  ...
  schemaUrl?: string   // ← never set in any return path
}

getProjectDetails declares schemaUrl?: string in its return type, but none of the function's return paths ever populate it. The destructuring at the call site (initAction.ts:173) doesn't include it either, and it's never forwarded downstream. init.bootstrap-app.test.ts:199 even asserts schemaUrl: undefined (carried from the old code).

This field is dead. Remove it from the return type and the test assertion. Fix this →

`initNextJs.ts:127` — fragile string replace on path segments

.replace(':route:', embeddedStudioRouteFilePath.slice(workDir.length).replace('src/', ''))

Plain string .replace('src/', '') only removes the first occurrence. If the workDir itself contains src/ (e.g. /home/user/src/myapp), .slice(workDir.length) strips the prefix correctly, but if the resulting relative path contains multiple src/ segments this would silently strip the wrong one. This is pre-existing code moved unchanged, but worth tracking.

Test changes — `exit(0)` removal is correct

All three test files (init.bootstrap-app, init.nextjs, init.staging-env) changed from:

expect(error?.oclif?.exit).toBe(0)

to:

if (error) throw error

This is correct. The original code called this.exit(0) after early-return paths (env-only, Next.js), which oclif treats as a thrown error with exit code 0. The refactored action functions simply return instead, which is cleaner and produces no error at all. The test update accurately reflects this.

binoy14 · 2026-03-30T21:55:41Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-30T21:55:46Z

📦 Bundle Stats — `@sanity/cli`

Compared against main (e9022171) · v6.2.1 (npm)

`@sanity/cli`

Metric	Value	vs main (`e902217`)	vs v6.2.1
Internal (raw)	2.1 KB	-	-
Internal (gzip)	799 B	-	-
Bundled (raw)	11.06 MB	-	+9.12 MB, +470.6%
Bundled (gzip)	2.07 MB	-	+1.60 MB, +335.8%
Import time	844ms	+0ms, +0.0%	+27ms, +3.3%

`bin:sanity`

Metric	Value	vs main (`e902217`)	vs v6.2.1
Internal (raw)	975 B	-	-
Internal (gzip)	460 B	-	-
Bundled (raw)	9.83 MB	-	+9.12 MB, +1286.7%
Bundled (gzip)	1.77 MB	-	+1.60 MB, +940.0%
Import time	NaNs	-	NaNs, NaN%

🗺️ View treemap · Artifacts

Details

Import time regressions over 10% are flagged with ⚠️
Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — `@sanity/cli-core`

Compared against main (e9022171) · v1.2.1 (npm)

Metric	Value	vs main (`e902217`)	vs v1.2.1
Internal (raw)	92.2 KB	-	+3.9 KB, +4.4%
Internal (gzip)	21.6 KB	-	+1.1 KB, +5.5%
Bundled (raw)	21.64 MB	-	+9.08 MB, +72.3%
Bundled (gzip)	3.43 MB	-	+1.58 MB, +85.9%
Import time	790ms	+3ms, +0.4%	+39ms, +5.2%

🗺️ View treemap · Artifacts

Details

Import time regressions over 10% are flagged with ⚠️
Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

github-actions · 2026-03-30T22:04:12Z

Coverage Delta

File	Statements
packages/@sanity/cli/src/actions/init/bootstrapTemplate.ts	0.0% (±0%)
packages/@sanity/cli/src/actions/init/initAction.ts	94.8% (new)
packages/@sanity/cli/src/actions/init/initApp.ts	96.0% (new)
packages/@sanity/cli/src/actions/init/initError.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initHelpers.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initNextJs.ts	86.7% (new)
packages/@sanity/cli/src/actions/init/initStudio.ts	87.0% (new)
packages/@sanity/cli/src/actions/init/scaffoldTemplate.ts	88.0% (new)
packages/@sanity/cli/src/actions/init/types.ts	100.0% (new)
packages/@sanity/cli/src/commands/init.ts	100.0% (+ 7.4%)
packages/@sanity/cli/src/telemetry/init.telemetry.ts	100.0% (±0%)

Comparing 11 changed files against main @ a43cfcca1f919e6d65832432231d8c698b0deda7

Overall Coverage

Metric	Coverage
Statements	83.0% (+ 0.0%)
Branches	73.0% (+ 0.0%)
Functions	83.0% (+ 0.1%)
Lines	83.5% (+ 0.0%)

github-actions · 2026-04-01T15:08:29Z

📦 Bundle Stats — `@sanity/cli`

Compared against main (a43cfcca)

`@sanity/cli`

Metric	Value	vs main (`a43cfcc`)
Internal (raw)	2.1 KB	-
Internal (gzip)	799 B	-
Bundled (raw)	10.95 MB	-
Bundled (gzip)	2.06 MB	-
Import time	823ms	+5ms, +0.6%

`bin:sanity`

Metric	Value	vs main (`a43cfcc`)
Internal (raw)	975 B	-
Internal (gzip)	460 B	-
Bundled (raw)	9.84 MB	-
Bundled (gzip)	1.77 MB	-
Import time	1.93s	-5ms, -0.2%

🗺️ View treemap · Artifacts

Details

Import time regressions over 10% are flagged with ⚠️
Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — `@sanity/cli-core`

Compared against main (a43cfcca)

Metric	Value	vs main (`a43cfcc`)
Internal (raw)	93.1 KB	-
Internal (gzip)	21.9 KB	-
Bundled (raw)	21.53 MB	-
Bundled (gzip)	3.41 MB	-
Import time	781ms	-1ms, -0.1%

🗺️ View treemap · Artifacts

Details

Import time regressions over 10% are flagged with ⚠️
Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — `create-sanity`

Compared against main (a43cfcca)

Metric	Value	vs main (`a43cfcc`)
Internal (raw)	976 B	-
Internal (gzip)	507 B	-
Bundled (raw)	50.7 KB	-
Bundled (gzip)	12.6 KB	-
Import time	❌ ChildProcess denied: node	-

Details

Import time regressions over 10% are flagged with ⚠️
Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

github-actions · 2026-04-01T15:19:39Z

Coverage Delta

File	Statements
packages/@sanity/cli/src/actions/init/bootstrapTemplate.ts	0.0% (±0%)
packages/@sanity/cli/src/actions/init/initAction.ts	94.8% (new)
packages/@sanity/cli/src/actions/init/initApp.ts	96.0% (new)
packages/@sanity/cli/src/actions/init/initError.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initHelpers.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initNextJs.ts	86.7% (new)
packages/@sanity/cli/src/actions/init/initStudio.ts	87.0% (new)
packages/@sanity/cli/src/actions/init/scaffoldTemplate.ts	88.0% (new)
packages/@sanity/cli/src/actions/init/types.ts	100.0% (new)
packages/@sanity/cli/src/commands/init.ts	100.0% (+ 7.4%)
packages/@sanity/cli/src/telemetry/init.telemetry.ts	100.0% (±0%)

Comparing 11 changed files against main @ 7af1594d79003801d6daeadeeb20508d184adb25

Overall Coverage

Metric	Coverage
Statements	83.1% (+ 0.0%)
Branches	72.9% (+ 0.0%)
Functions	83.4% (+ 0.1%)
Lines	83.6% (+ 0.0%)

github-actions · 2026-04-01T17:23:35Z

Coverage Delta

File	Statements
packages/@sanity/cli/src/actions/init/bootstrapTemplate.ts	0.0% (±0%)
packages/@sanity/cli/src/actions/init/initAction.ts	94.8% (new)
packages/@sanity/cli/src/actions/init/initApp.ts	96.0% (new)
packages/@sanity/cli/src/actions/init/initError.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initHelpers.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initNextJs.ts	86.7% (new)
packages/@sanity/cli/src/actions/init/initStudio.ts	87.0% (new)
packages/@sanity/cli/src/actions/init/scaffoldTemplate.ts	88.0% (new)
packages/@sanity/cli/src/actions/init/types.ts	100.0% (new)
packages/@sanity/cli/src/commands/init.ts	100.0% (+ 7.4%)
packages/@sanity/cli/src/telemetry/init.telemetry.ts	100.0% (±0%)

Comparing 11 changed files against main @ ef5ed4565d33b83d67cd66c6b3c335516e5b1132

Overall Coverage

Metric	Coverage
Statements	83.1% (+ 0.0%)
Branches	72.9% (+ 0.0%)
Functions	83.4% (+ 0.1%)
Lines	83.6% (+ 0.0%)

binoy14 mentioned this pull request Mar 30, 2026

feat(create-sanity): bundle init logic into single file #759

Draft

binoy14 force-pushed the bundled-create branch from a269206 to 4c8ce9f Compare April 1, 2026 15:07

binoy14 changed the title ~~refactor(init): move init logic to action pattern (#748)~~ refactor(init): move init logic to action pattern Apr 1, 2026

binoy14 force-pushed the bundled-create branch from 4c8ce9f to 5f9cfd7 Compare April 1, 2026 17:12

binoy14 force-pushed the bundled-create branch from 5f9cfd7 to e804d7a Compare April 6, 2026 17:40

mttdnt mentioned this pull request Apr 7, 2026

feat(telemetry): add standalone telemetry for create-sanity #892

Draft

rexxars added 2 commits April 10, 2026 14:16

refactor(init): move init logic to action pattern (#748)

021649e

refactor(init): split init flows into separate functions (#753)

d38cfc0

binoy14 force-pushed the bundled-create branch from e804d7a to d38cfc0 Compare April 10, 2026 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(init): move init logic to action pattern#845

refactor(init): move init logic to action pattern#845
binoy14 wants to merge 2 commits intomainfrom
bundled-create

binoy14 commented Mar 30, 2026

Uh oh!

claude bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

binoy14 commented Mar 30, 2026 •

edited by mttdnt

Loading

Uh oh!

github-actions bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

binoy14 commented Mar 30, 2026

Uh oh!

claude bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

initAction.ts:790 — dead schemaUrl field in return type

initNextJs.ts:127 — fragile string replace on path segments

Test changes — exit(0) removal is correct

Uh oh!

binoy14 commented Mar 30, 2026 • edited by mttdnt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Stats — @sanity/cli

@sanity/cli

bin:sanity

📦 Bundle Stats — @sanity/cli-core

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Delta

Overall Coverage

Uh oh!

github-actions bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Stats — @sanity/cli

@sanity/cli

bin:sanity

📦 Bundle Stats — @sanity/cli-core

📦 Bundle Stats — create-sanity

Uh oh!

github-actions bot commented Apr 1, 2026

Coverage Delta

Overall Coverage

Uh oh!

github-actions bot commented Apr 1, 2026

Coverage Delta

Overall Coverage

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claude bot commented Mar 30, 2026 •

edited

Loading

`initAction.ts:790` — dead `schemaUrl` field in return type

`initNextJs.ts:127` — fragile string replace on path segments

Test changes — `exit(0)` removal is correct

binoy14 commented Mar 30, 2026 •

edited by mttdnt

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading

📦 Bundle Stats — `@sanity/cli`

`@sanity/cli`

`bin:sanity`

📦 Bundle Stats — `@sanity/cli-core`

github-actions bot commented Mar 30, 2026 •

edited

Loading

github-actions bot commented Apr 1, 2026 •

edited

Loading

📦 Bundle Stats — `@sanity/cli`

`@sanity/cli`

`bin:sanity`

📦 Bundle Stats — `@sanity/cli-core`

📦 Bundle Stats — `create-sanity`