Skip to content

Pages update #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Pages update #3024

wants to merge 6 commits into from

Conversation

th-2021
Copy link
Contributor

@th-2021 th-2021 commented Oct 11, 2024

  • support gitlab with relative uri
  • add namespace-in-path support
  • add log-verbose option

@th-2021
Copy link
Contributor Author

th-2021 commented Oct 12, 2024

fixes #2923

kkimurak
kkimurak suggested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@kkimurak kkimurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I found 1 typo:

kkimurak
kkimurak suggested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@kkimurak kkimurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice that in my last review, but I just realized that we cannot set namespace_in_path to false. Can you check the review?

kkimurak
kkimurak reviewed Jun 7, 2025
View reviewed changes
kkimurak
kkimurak approved these changes Jun 7, 2025
View reviewed changes
Copy link
Contributor

@kkimurak kkimurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Wait for maintainer review and merge, Thank you for prompt response and contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kkimurak kkimurak kkimurak approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th-2021 @kkimurak