test(integration): add missing bits to make more tests pass @W-18763051 #5411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everything passed first try, which is kinda sus
# Conflicts: # packages/@lwc/integration-not-karma/helpers/wtr-utils.mjs
code is now in helpers/matchers/index.mjs
reduces test failures from 291 to 220
wjhsf
changed the title
rax-it
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In the initial migration from Karma to Web Test Runner, I was focused on just getting the new test framework functional, so I skipped a bunch of failing test files and implemented stubs for our custom matchers. In this PR, I've re-implemented our custom matchers (mostly changing the function signatures, rather than the logic). This caused a few new files to have test failures, presumably for similar reasons to whatever is causing the other files to fail. I validated that they're not failing due to incorrectly implemented matchers.
This PR also adds conditional imports for the synthetic shadow and ARIA reflection polyfills.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item