Time format is too opinionated; Timezone offset and seconds are necessary

[shashank1010]

I created a playground to test matchTime RegExp I found at here

https://regex101.com/r/CKXTQt/2
As you can see, it only treats a time string valid if it contains seconds and a timezone offset.

I'm using <input type="time" /> for a time/duration input; and the library treats the data input invalid.
It always only gives me hh:mm:ss OR hh:mm depending on how i've configured my input field (local time)

I also took the liberty to modified the RegExp that works for both hh:mm and hh:mm:ss, along with time timezone offset (z | +00:00) formats.
https://regex101.com/r/u0mN8x/1

The two are also equally performant.

I created a pull request #70 for you to review.

[sagold]

Hi Shashank,

thank you for your contribution!

The time format validation is written with json-schema-spec-test-suite as the source of truth. The current implementation passes all tests, which is important to stay spec compliant to the schema and other validators.

If the tests pass (yarn test) I am very happy to merge your PR. Unfortunately, I did not setup tests for MRs yet and I will only be able to test this end of next week.

Note, that you can fully customize (overwrite) format-validation for your context and needs.

Cheers,
Sascha

[sagold]

A short summary why we cannot merge this change request:

JSON Schema Spec uses RFC3339 for the format time:
https://json-schema.org/draft/2020-12/json-schema-validation#section-7.3.1

RFC3339 specifies time using the following (partial) ABNF:

time-offset  = "Z" / time-numoffset
partial-time = time-hour ":" time-minute ":" time-second
                     [time-secfrac]
full-time    = partial-time time-offset

https://datatracker.ietf.org/doc/rfc3339/

Thus, seconds and timezone are mandatory.

I would propose to add your PR to the documentation as a working example to add a custom time validator. What do you think?

Cheers
Sascha

[shashank1010]

Hi Sascha,

thanks you for your consideration.
I failed to fully read the documentation and suggested a change which goes against the JSON Schema specification. Thanks for pointing me in the right direction.

I appreciate your proposal, I will make the necessary changes changes to my PR with an example in to overwrite the time validator.

Cheers!
Shashank

[shashank1010]

I realised that a lot had changed in the library.
In #72 I have added a working example explaining how to overwrite a format validator.

Hope the language is acceptable. :)

Cheers!

[sagold]

Hi Shashank,

your language is perfect. Thank you so much for your contribution!

Cheers
Sascha