fix some wrong syntax #40747
Open
fix some wrong syntax #40747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 07ed645; changes) is ready! 🎉 |
dcoudert
reviewed
Sep 1, 2025
| @@ -11258,7 +11258,7 @@ def is_equivalent(self, other): | |||
| False | |||
| """ | |||
| A = self.minimization().relabeled() | |||
| [initial] = A.initial_states() | |||
| initial, = A.initial_states() | |||
There was a problem hiding this comment.
are you sure it's the correct syntax ?
sage: a, = [2, 3]
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
Cell In[1], line 1
----> 1 a, = [Integer(2), Integer(3)]
ValueError: too many values to unpack (expected 1)
sage: a, *_ = [2, 3]
sage: a
2
sage: a, *_ = [2, 3, 4]
sage: a
2There was a problem hiding this comment.
yes, it works to unpack a list or tuple with one element
sage: moulinsart, = [421]
| @@ -680,7 +680,7 @@ def representation_matrix_for_simple_transposition(self, i): | |||
| M = matrix(self._ring, digraph.num_verts()) | |||
| for g in digraph.connected_components_subgraphs(): | |||
| if g.num_verts() == 1: | |||
| [v] = g.vertices(sort=True) | |||
| v, = g.vertices(sort=True) | |||
There was a problem hiding this comment.
same question here. may be you can use v = g.vertices(sort=True)[0]
| @@ -2460,7 +2460,7 @@ def bridges(G, labels=True): | |||
| if len(b) == 2 and not tuple(b) in ME: | |||
| if labels: | |||
| if multiple_edges: | |||
| [label] = G.edge_label(b[0], b[1]) | |||
| label, = G.edge_label(b[0], b[1]) | |||
| @@ -1548,7 +1548,7 @@ cdef class TreelengthConnected: | |||
| cdef frozenset reduced_cut | |||
|
|
|||
| if len(cc) == 1: | |||
| [v] = cc | |||
| v, = cc | |||
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 4, 2025
sagemathgh-40747: fix some wrong syntax found using ` gg "^\s*\[[a-zA-Z0-9, ]*\] = " src/sage/ ` ### 📝 Checklist - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. URL: sagemath#40747 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found using
`
gg "^\s*[[a-zA-Z0-9, ]*] = " src/sage/
`
📝 Checklist