Skip to content

Migrate Mathjax detection to meson #40404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

Moves the detection of the MathJax source file to meson.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@antonio-rojas
Copy link
Contributor

Looks like there are some leftover references to the mathjax spkg

[2/190] Generating src/doc/doc-src with a custom command (wrapped by meson to set env)
Traceback (most recent call last):
  File "/build/sagemath-doc-git/src/sage/build/bin/sage-package", line 40, in <module>
    run()
    ~~~^^
  File "/build/sagemath-doc-git/src/sage/build/bin/../sage_bootstrap/cmdline.py", line 520, in run
    app.dependencies(*args.package_class, types=types, format=args.format)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/sagemath-doc-git/src/sage/build/bin/../sage_bootstrap/app.py", line 183, in dependencies
    elif format == 'rst' and Package(dep).has_file('SPKG.rst'):
                             ~~~~~~~^^^^^
  File "/build/sagemath-doc-git/src/sage/build/bin/../sage_bootstrap/package.py", line 53, in __new__
    self.__init__(package_name)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/build/sagemath-doc-git/src/sage/build/bin/../sage_bootstrap/package.py", line 85, in __init__
    self._init_type()
    ~~~~~~~~~~~~~~~^^
  File "/build/sagemath-doc-git/src/sage/build/bin/../sage_bootstrap/package.py", line 550, in _init_type
    with open(os.path.join(self.path, 'type')) as f:
         ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/build/sagemath-doc-git/src/sage/build/pkgs/mathjax/type'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants