-
-
Notifications
You must be signed in to change notification settings - Fork 635
cleanup and code details in cluster_algebra_quiver #40393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in file mutation_type.py
, several elif
could be turned to if
and some else
could be removed, in particular in method _connected_mutation_type
Oui, ce code est asse alambiqué. On peut garder ca pour une autre fois ? |
oui, pas de souci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
some changes as suggested by pycodestyle and ruff
also some further minor code enhancements,
and shortening one long time doctest
📝 Checklist