Skip to content

cleanup and code details in cluster_algebra_quiver #40393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

some changes as suggested by pycodestyle and ruff

also some further minor code enhancements,

and shortening one long time doctest

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in file mutation_type.py, several elif could be turned to if and some else could be removed, in particular in method _connected_mutation_type

@fchapoton
Copy link
Contributor Author

Oui, ce code est asse alambiqué. On peut garder ca pour une autre fois ?

@dcoudert
Copy link
Contributor

oui, pas de souci.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants