-
-
Notifications
You must be signed in to change notification settings - Fork 648
bump matplotlib (with its deps) to 3.10.1 #39789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@enriqueartal does this fix the issue you reported? |
I am unable to compile matplotlib, it complains it cannot download freetype; I can do it but apparently the script cannot. |
Update. I installed matplotlib with |
sorry, there is an unexpected by me snag - it requires an old version of meson to build. |
It seems that meson and matplotlib folks have a philosophical disagreement whether meson should support links, see So now we have an unpleasant choice of
|
we really don't want an old version of freetype anywhere close to our systems. it's some silly matplotlib leftover which they forgot all about, while switching to meson... |
I guess there is no easy solution. Is it one to install matplotlib with |
This is incorrect. First, the issue is with meson-python and not meson: if you were, you would have to downgrade meson-python not meson. Second, there is no disagreement about supporting symlinks in meson-python: the meson-python maintainer stated that support for symklinks in sdists is desired feature. However, the matplotlib maintainers that submitted the PR adding the support back have not followed up after a first round of comments on the path. Third, the issue is with generating an sdist from Matplotlib, not with compiling Matplotlib |
@enriqueartal - does this work now? It does for me (not that I understand why it works now - perhaps passing these extra parameters bypasses the version check) EDIT: the latest commit enables an alternative build, which does not use meson-py, to succeed. |
Make is successful, |
Documentation preview for this PR (built with commit b87217c; changes) is ready! 🎉 |
positive review? |
sagemathgh-39789: bump matplotlib (with its deps) to 3.10.1 Sage's current matplotlib in some cases wants numpy 1. See https://groups.google.com/g/sage- release/c/TkPM0xL2fFA/m/qQwVExhcBAAJ Thus we bump it to 3.10,1, along with its deps <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39789 Reported by: Dima Pasechnik Reviewer(s): Enrique Manuel Artal Bartolo
Sage's current matplotlib in some cases wants numpy 1.
See https://groups.google.com/g/sage-release/c/TkPM0xL2fFA/m/qQwVExhcBAAJ
Thus we bump it to 3.10,1, along with its deps
⌛ Dependencies