Skip to content

New ray class #39525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

New ray class #39525

wants to merge 33 commits into from

Conversation

fchapoton
Copy link
Contributor

this is a revival of #15829

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@fchapoton
Copy link
Contributor Author

@AurelPage
j'ai rebasé, mais il reste du boulot

@fchapoton fchapoton added the sd128 tickets of Sage Days 128 Le Teich label Feb 14, 2025
@fchapoton fchapoton marked this pull request as draft February 14, 2025 09:24
Copy link

github-actions bot commented Feb 14, 2025

Documentation preview for this PR (built with commit e675d41; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

fchapoton commented Feb 15, 2025

The 2 failing doctests in src/sage/modular/hecke_character.py should be easy to fix by an expert in the field.

@fchapoton
Copy link
Contributor Author

J'ai le sentiment de me mélanger les pinceaux entre bnrinit et gcharinit. Je crois que le ticket parle plutot du "ray class group". Un expert pourrait-il aider à clarifier les choses ? en particulier concernant la fonction L ?

@AurelPage
Copy link
Contributor

Frédéric, ne touche pas aux gchar pour le moment. bnrinit permet de calculer des groupes de classes de rayon et leurs caractères, qui sont exactement les caractères de Hecke d'ordre fini. gcharinit permet de traiter les caractères de Hecke arbitraires, donc potentiellement d'ordre infini et potentiellement transcendants, je pense qu'il vaut mieux garder ça pour un travail d'intégration séparé.

@fchapoton
Copy link
Contributor Author

ok, les fonctions L marchent, mais il manque encore de la doc. Et surtout l'aide d'un specialiste pour me dire si les doctests qui ne passent pas sont des erreurs au sens mathematique ou pas.

@AurelPage
Copy link
Contributor

Merci ! Je vais regarder mais je n'aurai pas trop le temps avant une semaine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: number theory sd128 tickets of Sage Days 128 Le Teich
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants