add Rémy Oudompheng's implementation of the BMSS algorithm #36285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rémy Oudompheng <[email protected]>
kwankyu
reviewed
Sep 17, 2023
Collaborator
|
The achievement is impressive. I made one comment. Otherwise, lgtm. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Thanks for taking care of this. Please note that this algorithm requires that field characteristic is "large enough" ( |
Member
|
merge conflict |
SageMath version 10.2.beta4, Release Date: 2023-09-24
Member
Author
|
Resolved merge conflict and added some new code to fail more gracefully when the limitation mentioned in #36285 (comment) is encountered. |
kwankyu
reviewed
Sep 26, 2023
kwankyu
reviewed
Sep 26, 2023
|
Documentation preview for this PR (built with commit 81996bb; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 28, 2023
…gorithm The BMSS algorithm computes (the kernel polynomial of) a *normalized* isogeny from its degree $\ell$ and its domain and codomain in time $\widetilde O(\ell)$. Currently Sage uses Stark's algorithm for the same task, which takes time in $\Omega(\ell^2)$. An implementation in Sage of the BMSS algorithm is available thanks to @remyoudompheng, and in this patch we add it to the Sage library (following Rémy's suggestion). Benchmark results for isogenies over a ~280-bit prime field (red is Stark, blue is BMSS; axes are degree $\ell$ and seconds taken):  URL: sagemath#36285 Reported by: Lorenz Panny Reviewer(s): github-actions[bot], Kwankyu Lee, Lorenz Panny
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 1, 2023
sagemathgh-36285: add Rémy Oudompheng's implementation of the BMSS algorithm The BMSS algorithm computes (the kernel polynomial of) a *normalized* isogeny from its degree $\ell$ and its domain and codomain in time $\widetilde O(\ell)$. Currently Sage uses Stark's algorithm for the same task, which takes time in $\Omega(\ell^2)$. An implementation in Sage of the BMSS algorithm is available thanks to @remyoudompheng, and in this patch we add it to the Sage library (following Rémy's suggestion). Benchmark results for isogenies over a ~280-bit prime field (red is Stark, blue is BMSS; axes are degree $\ell$ and seconds taken):  URL: sagemath#36285 Reported by: Lorenz Panny Reviewer(s): github-actions[bot], Kwankyu Lee, Lorenz Panny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BMSS algorithm computes (the kernel polynomial of) a normalized isogeny from its degree$\ell$ and its domain and codomain in time $\widetilde O(\ell)$ . Currently Sage uses Stark's algorithm for the same task, which takes time in $\Omega(\ell^2)$ . An implementation in Sage of the BMSS algorithm is available thanks to @remyoudompheng, and in this patch we add it to the Sage library (following Rémy's suggestion).
Benchmark results for isogenies over a ~280-bit prime field (red is Stark, blue is BMSS; axes are degree$\ell$ and seconds taken):