Conversation
Member
Uxio0
commented
Apr 19, 2022
Uxio0
commented
- Closes Add proper support for EIP1559 #307
- Add method to fix old transactions
- Closes #307 - Add method to fix old transactions
fmrsabino
reviewed
Apr 20, 2022
Comment on lines
+25
to
+27
| self.style.SUCCESS( | ||
| f"Fixing tx with tx-hash={ethereum_tx.tx_hash}" | ||
| ) |
Contributor
There was a problem hiding this comment.
Should we use the logger instead here?
Member
Author
There was a problem hiding this comment.
No, for command line scripts you should do it this way: https://docs.djangoproject.com/en/4.0/howto/custom-management-commands/
| ) | ||
| ) | ||
| ethereum_txs.append(ethereum_tx) | ||
| if len(ethereum_txs) == 500: |
Member
Author
There was a problem hiding this comment.
Arbitrary, to prevent overloading the nodes
fmrsabino
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.