Fix failing builds on Java 11 and newer, update a bunch of dependencies, add java21 support #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@slawekjaranowski can you take a look at this when you have some time please? 🙂 |
slawekjaranowski
requested changes
Jan 16, 2024
|
slawekjaranowski
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a bunch of dependencies.
In doing so it fixes the currently failing builds for java 11 and java 17. See https://github.com/s4u/sign-maven-plugin/actions/runs/7056372309/job/19208245215#step:4:3001 for an example.
This error was caused by an old version of the karaf-maven-plugin in one of the integration tests.
As a side effect of the updates, building the plugin with java 21 now works fine as well.
I intentionally didn't update some things like the maven version or mockito to keep the current baseline of java 8 support.