Completed the attribute support for servers. #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
requested changes
Feb 16, 2021
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
- please add use case with new properties to
settings.test.js - please update
READMEto show new properties - please squash to one final commit
and thank you for PR
Contributor
Author
|
Can't you just squash on the merge? (Is the Allow squash merging option enabled under Settings > Options > Merge button?) |
slawekjaranowski
approved these changes
Feb 16, 2021
Member
|
@awhitford once again thanks you, I will prepare next version until week end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
passwordis optional because aprivateKeymay be used.Resolves #92.