Skip to content
This repository was archived by the owner on Dec 1, 2019. It is now read-only.
This repository was archived by the owner on Dec 1, 2019. It is now read-only.

Breaking change in 2.1.0 #200

@ThaNarie

Description

@ThaNarie

Just ran a fresh travis build and something broke that we didn't change.

[Error: ENOENT: no such file or directory, open 'config/typings/index.d.ts']

Comparing the npm ls from the old and the new installs, we noticed that this plugin was updated from 2.0.1 to 2.1.0

In config/tsconfig.test.json we have a include to "typings/index.d.ts".
If we change it to "../typings/index.d.ts" it now works.

I believe this change was introduced in #188.
We are running npm test from the root of the project, and the config file is in config. Changing from cwd() to dirname(configFilePath) explains this behavior.

Since this clearly is a breaking change it should not have been published as 2.1.0 (minor) but as 3.0.0 (major).
I also don't see a github release and changelog update, so maybe this was not intentional?

Should we update our code, or is npm going to be 'reverted' somehow?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions