Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 97.04% 97.05% +0.01%
==========================================
Files 20 20
Lines 4232 4247 +15
==========================================
+ Hits 4107 4122 +15
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
left a comment
There was a problem hiding this comment.
Do we want to backport this to 0.103.x?
cpu
left a comment
There was a problem hiding this comment.
Seems reasonable. The special-case V1 trust anchor parsing code path doesn't have matching skip logic in this diff, but the fields are spec'd to be present only in v2/v3 so that seems correct to me.
There's really no reason for anyone to be generating certs with these fields (and they're rare enough that x509-parser's support for recognizing them was broken for a good while without anyone complaining) but the 5280 SHOULD for relying parties to parse but ignore these seems reasonable to honor.
I don't think it's important enough to justify the work personally. |
fixes #418
addresses one item in #70