Skip to content

Add valid_uri_names() method to Cert#404

Merged
djc merged 1 commit intorustls:mainfrom
alex:add-valid-uri-names
Oct 28, 2025
Merged

Add valid_uri_names() method to Cert#404
djc merged 1 commit intorustls:mainfrom
alex:add-valid-uri-names

Conversation

@alex
Copy link
Contributor

@alex alex commented Oct 28, 2025

Returns an iterator over URI names from the subject alternative names extension, following the same pattern as valid_dns_names().

refs #9

🤖 Generated with Claude Code

Returns an iterator over URI names from the subject alternative names
extension, following the same pattern as valid_dns_names().

refs rustls#9

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.60%. Comparing base (74a40b2) to head (d639655).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   97.57%   97.60%   +0.02%     
==========================================
  Files          20       20              
  Lines        4089     4097       +8     
==========================================
+ Hits         3990     3999       +9     
+ Misses         99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me.

@djc djc added this pull request to the merge queue Oct 28, 2025
Merged via the queue into rustls:main with commit 22ffd27 Oct 28, 2025
38 checks passed
@alex
Copy link
Contributor Author

alex commented Oct 28, 2025

Awesome, thanks for the quick review/merge!

I'm not sure what rustls-webpki's release cadence is, but if there's anything I can help with, please let me know!

@alex alex deleted the add-valid-uri-names branch October 28, 2025 16:54
@djc
Copy link
Member

djc commented Oct 28, 2025

main is currently targeting 0.104.x alphas, but I think you could backport this to rel-0.103 (and add a version bump).

@alex
Copy link
Contributor Author

alex commented Oct 28, 2025

Sounds great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants