Skip to content

0.104.0: Take MSRV of 1.83#388

Merged
ctz merged 4 commits intomainfrom
jbp-msrv-1.83
Oct 2, 2025
Merged

0.104.0: Take MSRV of 1.83#388
ctz merged 4 commits intomainfrom
jbp-msrv-1.83

Conversation

@ctz
Copy link
Member

@ctz ctz commented Sep 24, 2025

Treating this as a breaking change out of caution, as the previous (and new) MSRV doesn't have a MSRV-aware resolver.

re #377

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (94d957c) to head (5be3852).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          20       20           
  Lines        4104     4104           
=======================================
  Hits         3999     3999           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member

djc commented Sep 24, 2025

Should we hold off on merging this for a little bit, until we get feedback on the EKU validation API and can merge it?

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc
Copy link
Member

djc commented Oct 2, 2025

Should merge the following before we release:

See also:

@djc
Copy link
Member

djc commented Oct 2, 2025

Treating this as a breaking change out of caution, as the previous (and new) MSRV doesn't have a MSRV-aware resolver.

I don't think doing a breaking change just for the MSRV makes sense, as that is uncommon for the ecosystem (MSRV-aware resolver or not). But we have some actually breaking changes that will help.

@ctz ctz added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit bca63ad Oct 2, 2025
40 checks passed
@ctz ctz deleted the jbp-msrv-1.83 branch October 2, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants