Do not include bettertls README file in published crates#351
Merged
djc merged 1 commit intorustls:mainfrom May 10, 2025
decathorpe:main
Merged
Do not include bettertls README file in published crates#351djc merged 1 commit intorustls:mainfrom decathorpe:main
djc merged 1 commit intorustls:mainfrom
decathorpe:main
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 20 20
Lines 4470 4470
=======================================
Hits 4377 4377
Misses 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpu
approved these changes
May 10, 2025
Member
|
Nice catch, thank you |
djc
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all
README.mdfiles in the crate are included when publishing, which includesthird-party/bettertls/README.md. This looks unintentional. Using an absolute path in thepackage.includesetting instead (i.e./README.md) causes only the toplevel README file to get included.