Skip to content

Avoid races during revocation fetches#78

Open
djc wants to merge 4 commits intomainfrom
racing
Open

Avoid races during revocation fetches#78
djc wants to merge 4 commits intomainfrom
racing

Conversation

@djc
Copy link
Member

@djc djc commented Feb 23, 2026

Fixes #31.

@djc djc requested a review from ctz February 23, 2026 10:41
/// A timestamp could not be parsed.
UPKI_ERR_REVOCATION_INVALID_TIMESTAMP = 76,
/// Failed to decode a manifest file.
UPKI_ERR_REVOCATION_MANIFEST_DECODE = 77,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we renumber these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think renumbering at this point is OK, in the end we'll want to avoid deleting, renaming or renumbering items altogether

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 23, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing racing (eaedcd2) with main (e50cbf9)

Open in CodSpeed

@djc djc force-pushed the racing branch 2 times, most recently from af51e70 to 20fa032 Compare February 23, 2026 10:59
/// A timestamp could not be parsed.
UPKI_ERR_REVOCATION_INVALID_TIMESTAMP = 76,
/// Failed to decode a manifest file.
UPKI_ERR_REVOCATION_MANIFEST_DECODE = 77,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think renumbering at this point is OK, in the end we'll want to avoid deleting, renaming or renumbering items altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider revocation cache uses during a fetch

2 participants