Merged
Conversation
23.11 -> 24.05, the latest stable at the time of writing.
Takes latest github:hercules-ci/flake-parts input.
Updates stable/nightly toolchains to latest.
Fixes clippy findings of the form: ``` error: doc list item missing indentation --> rustls-platform-verifier/src/tests/verification_real_world/mod.rs:17:5 | 17 | //! with the measures mentioned in the next paragraphs, the operating system | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` ```
```
error: the borrowed expression implements the required traits
--> rustls-platform-verifier/src/verification/android.rs:193:53
|
193 | JValue::from(env.new_string(&server_name.to_str())?),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `server_name.to_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
```
complexspaces
approved these changes
Jul 29, 2024
Collaborator
complexspaces
left a comment
complexspaces
left a comment
There was a problem hiding this comment.
Thanks for the tidyup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.mdwhen preparing android-release-support 0.1.1, rustls-platform-verifier 0.3.3 #114