Fix: mark SAN as critical when subject is empty #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added a commit
to howardjohn/ztunnel
that referenced
this pull request
Jan 17, 2025
Part of istio#1431 Fails without rustls/rcgen#311
This was referenced Jan 17, 2025
djc
approved these changes
Jan 18, 2025
|
Seems reasonable to me! |
cpu
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Thanks for fixing this. I agree it's the right approach (and matches Go x509's behaviour - always reassuring).
Would you mind adding a small test w/ x509-parser to prevent regression? Something like generating two certs, both with SANs, but only one with a subject, and then asserting the criticality of the SAN ext matches expectation would be great.
est31
approved these changes
Jan 19, 2025
I'll push a test commit for this in a moment. There's no use waiting on a test if it's quick to write. |
cpu
reviewed
Jan 19, 2025
istio-testing
pushed a commit
to istio/ztunnel
that referenced
this pull request
May 7, 2025
* Make csr test stricter and more correct Part of #1431 Fails without rustls/rcgen#311 * update rcgen Signed-off-by: Yuval Kohavi <[email protected]> * fix merge issue * format fix Signed-off-by: Yuval Kohavi <[email protected]> --------- Signed-off-by: Yuval Kohavi <[email protected]> Co-authored-by: John Howard <[email protected]>
yuval-k
added a commit
to yuval-k/ztunnel
that referenced
this pull request
May 7, 2025
…o#1550) * Make csr test stricter and more correct Part of istio#1431 Fails without rustls/rcgen#311 * update rcgen Signed-off-by: Yuval Kohavi <[email protected]> * fix merge issue * format fix Signed-off-by: Yuval Kohavi <[email protected]> --------- Signed-off-by: Yuval Kohavi <[email protected]> Co-authored-by: John Howard <[email protected]>
istio-testing
pushed a commit
to istio/ztunnel
that referenced
this pull request
May 8, 2025
…1552) * Make csr test stricter and more correct Part of #1431 Fails without rustls/rcgen#311 * update rcgen * fix merge issue * format fix --------- Signed-off-by: Yuval Kohavi <[email protected]> Co-authored-by: John Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310