Conversation
cpu
approved these changes
Sep 18, 2024
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Nice, this looks good.
One thought: I had also started to sketch this out in rustls/pemfile a while back. In my WIP branch I had also added a server_ech_configs() fn that returned Result<(PrivatePkcs8KeyDer<'static>, EchConfigListBytes<'static>), io::Error> since I imagine most non-test use-cases will want to load both the private key and the ECH config in one go.
Do you think there's any value in adding something like that to this branch?
ctz
force-pushed
the
jbp-pem
branch
5 times, most recently
from
6cd7872 to
dddfb8d
Compare
ctz
force-pushed
the
jbp-pem
branch
2 times, most recently
from
8d5f39e to
5786284
Compare
Member
Author
I've added a separate commit containing one solution to this; WDYT? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts the "ECHCONFIG" section delimiter proposed in https://www.ietf.org/archive/id/draft-farrell-tls-pemesni-05.html.
(comes after #53)