Merged
Conversation
ctz
approved these changes
Apr 7, 2024
Member
ctz
left a comment
ctz
left a comment
There was a problem hiding this comment.
I feel like behaviour tests that strictly use the public API should also not be in src/ (rationale: it's easy to accidentally neglect to export a public API)
cpu
approved these changes
Apr 7, 2024
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
I feel like behaviour tests that strictly use the public API should also not be in src/
Agreed. Moving some of the existing tests seems like a good follow-up.
Member
Author
|
I'll follow up with those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO this is a more appropriate/conventional home for test data (compared to inside
src).(Context: looking at rustls/rustls#1462 again.)